]> git.dujemihanovic.xyz Git - u-boot.git/commit
ufs: Use 'TASK_TAG' to construct the ucd_req_ptr->header.dword_0
authorBhupesh Sharma <bhupesh.sharma@linaro.org>
Sun, 2 Jul 2023 19:09:12 +0000 (00:39 +0530)
committerTom Rini <trini@konsulko.com>
Fri, 14 Jul 2023 19:21:08 +0000 (15:21 -0400)
commit820801eacccd1b6913b101ffb2f518aa1bc24fdf
treeb6b5bce6fb45ceb3fc57cf4703fcad425dbfdfd3
parent910b01c27c0499ae8f84104a0db745dd3a056c04
ufs: Use 'TASK_TAG' to construct the ucd_req_ptr->header.dword_0

Instead of using the hard-coded value of 0x1f, use 'TASK_TAG'
macro instead to construct the ucd_req_ptr->header.dword_0

This is in sync with what the Linux UFS driver does, i.e.
set the byte0 equal to TASK_TAG (see [1]).

Setting it to a fixed value of 0x1f is wrong as we define
TASK_TAG as 0 inside u-boot ufs framework. So, instead we
should  use the macro value directly.

[1]. https://github.com/torvalds/linux/blob/master/drivers/ufs/core/ufshcd.c#L2705

Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
drivers/ufs/ufs.c