]> git.dujemihanovic.xyz Git - u-boot.git/commit
lcd: split splash code into its own function
authorNikita Kiryanov <nikita@compulab.co.il>
Tue, 3 Feb 2015 11:32:32 +0000 (13:32 +0200)
committerAnatolij Gustschin <agust@denx.de>
Tue, 10 Feb 2015 12:31:58 +0000 (13:31 +0100)
commit7bf71d1f55d31a81ade8dd0fc72f06e4672689d0
tree24b4f3eb0b35b5002131a307d33075ff602e8473
parent033167c4c5a9a31768f690353ce26be021ad9c36
lcd: split splash code into its own function

lcd_logo() currently performs tasks well beyond just displaying the logo.
It has code which displays splash image, it has logic which determines
when the different display features are displayed, and it is coupled with
the lcd console because it holds the responsibility of returning the
lcd console base address.

Make lcd_logo() just about the logo by:
* Moving splash image display code into a dedicated function
* Moving the logic regarding when various features are displayed to
  lcd_clear() (which is arguably not the correct name for housing such
  code either, but it is currently the most fitting location code wise)
* Move the responsibility of setting the console base address to
  lcd_clear() too.

Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
Reviewed-by: Simon Glass <sjg@chromium.org>
Tested-by: Bo Shen <voice.shen@atmel.com>
Tested-by: Josh Wu <josh.wu@atmel.com>
Cc: Bo Shen <voice.shen@atmel.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Anatolij Gustschin <agust@denx.de>
common/lcd.c
common/splash.c
include/splash.h