]> git.dujemihanovic.xyz Git - u-boot.git/commit
efi_loader: fix the return codes of UninstallProtocol
authorIlias Apalodimas <ilias.apalodimas@linaro.org>
Tue, 20 Jun 2023 06:19:30 +0000 (09:19 +0300)
committerHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Sat, 15 Jul 2023 09:20:41 +0000 (11:20 +0200)
commit748cb553ff9c1fefdfad540ea949c869ee9e3306
treee17360c363877ec75ccabf2a46a5b34a3e3337c0
parent747d16d93c3b03e835925dd9ecb8f8d0b8d1ad22
efi_loader: fix the return codes of UninstallProtocol

Up to now we did not check the return value of DisconnectController.
A previous patch is fixing that taking into account what happened during
the controller disconnect.  But that check takes place before our code
is trying to figure out if the interface exists to begin with.  In case a
driver is not allowed to unbind -- e.g returning EFI_DEVICE_ERROR, we
will end up returning that error instead of EFI_NOT_FOUND.

Add an extra check on the top of the function to make sure the protocol
interface exists before trying to disconnect any drivers

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
lib/efi_loader/efi_boottime.c