]> git.dujemihanovic.xyz Git - u-boot.git/commit
spi: cadence_qspi: Fix OSPI boot issue
authorVenkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
Thu, 14 Nov 2024 06:20:45 +0000 (11:50 +0530)
committerMichal Simek <michal.simek@amd.com>
Tue, 19 Nov 2024 14:56:44 +0000 (15:56 +0100)
commit5a24caca0647c2bcc9c1fcb35ac610a35b6e11d0
tree5957fc94c67b4b7f0055eb16f89d47c727f83ffd
parent159dfef2615dcc83acf4e28bbed0387d72066b0c
spi: cadence_qspi: Fix OSPI boot issue

Moving the hw_reset function from the controller driver to
the NOR framework has caused the OSPI reset not to be triggered
in the Cadence driver's probe function. As a result, reading the
flash ID during SPI calibration is incorrect, and the
CQSPI_REG_RD_DATA_CAPTURE is set with an invalid value.This makes
it unable to read the flash ID properly.
To solve this problem, it's suggested to skip SPI calibration and
instead retrieve the read_delay directly from the device tree.

Skipping SPI calibration doesn't bring harm since there's no need
for the flash golden values stored during SPI calibration.
Instead, they are now read during the spi_nor_read_id call in the
NOR framework.

Signed-off-by: Tejas Bhumkar <tejas.arvind.bhumkar@amd.com>
Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
Link: https://lore.kernel.org/r/20241114062045.17581-1-venkatesh.abbarapu@amd.com
Signed-off-by: Michal Simek <michal.simek@amd.com>
drivers/spi/cadence_qspi.c