]> git.dujemihanovic.xyz Git - u-boot.git/commit
common: update: fix an "unused" warning against update_flash()
authorAKASHI Takahiro <takahiro.akashi@linaro.org>
Thu, 19 Nov 2020 00:37:19 +0000 (09:37 +0900)
committerTom Rini <trini@konsulko.com>
Wed, 2 Dec 2020 21:21:58 +0000 (16:21 -0500)
commit50efdf2c6ffe82a14cb7bf20a1abf55cff2ad135
tree8b219948ed643e5fb48942f9b1e39a7ee4d2a449
parentd211e0418fed8adf4ffa7c31f067e367fb26a081
common: update: fix an "unused" warning against update_flash()

Since update_flash() is used only in update_tftp(), it should be
guarded with appropriate config options.

After the commit 3149e524fc1e, common/update.c will be built under
either CONFIG_UDATE_TFTP, CONFIG_DFU_TFTP or CONFIG_UPDATE_FIT.
Since CONFIG_UPDATE_FIT, hence fit_update(), doesn't rely on
update_flash(), the compiler may cause an "unused" warning if
CONFIG_UPDATE_FIT=y and CONFIG_UPDATE_TFTP=n and CONFIG_DFU_TFTP=n.

This is, for example, the case for sandbox defconfig where
EFI_CAPSULE_FIRMWARE_FIT is enabled for test purpose.

Fixes: 3149e524fc1e ("common: update: add a generic interface for FIT
       image")
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
common/update.c