]> git.dujemihanovic.xyz Git - u-boot.git/commit
net: rtl8169: Fix return value for rtl_send_common
authorOleksandr Tymoshenko <gonzo@bluezbox.com>
Fri, 1 Jul 2016 20:22:00 +0000 (13:22 -0700)
committerJoe Hershberger <joe.hershberger@ni.com>
Wed, 6 Jul 2016 15:45:11 +0000 (10:45 -0500)
commit4c64c4db3b87818318ed8b4cd6907c508aaf04ce
tree7269bd2af9ebd622030a5c22d5d91b41b7daf789
parente4ead4a21db266c84051279ed4ceeab72981df8c
net: rtl8169: Fix return value for rtl_send_common

Return value of rtl_send_common propogates unmodified all the way
up to eth_send and further to API consumer if CONFIG_API is enabled.
Previously rtl_send_common returned number of bytes sent on success
which was erroneouly detected as error condition by API consumers
that checked for operation success by comparing return value with 0.

Switch rtl_send_common to use common convention: return 0 on success
and negative value for failure.

Cc: Stephen Warren <swarren@nvidia.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>
Signed-off-by: Oleksandr Tymoshenko <gonzo@bluezbox.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
drivers/net/rtl8169.c