]> git.dujemihanovic.xyz Git - u-boot.git/commit
disk: part_efi: fix regression due to incorrect buffer usage
authorStephen Warren <swarren@nvidia.com>
Fri, 28 Oct 2011 09:21:46 +0000 (09:21 +0000)
committerWolfgang Denk <wd@denx.de>
Mon, 5 Dec 2011 21:23:21 +0000 (22:23 +0100)
commit4715a81136049167160230efd28eb9d48eeded1f
tree286b4133038349c2d8fbc96491ee73e4305a455b
parent1cdabc4bc78f98155a51890a3077473d7a4d3426
disk: part_efi: fix regression due to incorrect buffer usage

Commit deb5ca80275e8cfa74d5680b41204e08a095eca5 "disk: part_efi: fix
**pgpt_pte == NULL" modified the code to pass "&gpt_head" to
is_gpt_valid() rather than the previous "gpt_head". However, gpt_head
is a pointer to the buffer, not the actual buffer, since it was allocated
using ALLOC_CACHE_ALIGN_BUFFER. This caused is_gpt_valid() to read the
disk block onto the stack rather than into the buffer, causing the
code to fail.

This change reverts that portion of the commit mentioned above.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Doug Anderson <dianders@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Acked-by: Mike Frysinger <vapier@gentoo.org>
Tested-by: Anton Staaf <robotboy@chromium.org>
disk/part_efi.c