]> git.dujemihanovic.xyz Git - u-boot.git/commit
mbedtls: remove MBEDTLS_HAVE_TIME
authorIlias Apalodimas <ilias.apalodimas@linaro.org>
Fri, 6 Dec 2024 10:56:45 +0000 (12:56 +0200)
committerTom Rini <trini@konsulko.com>
Fri, 6 Dec 2024 23:47:23 +0000 (17:47 -0600)
commit45f05f681224d88d1b170063001b59edc8fc24cf
tree11b196f2d9ed60d4c0879967c9545454f4050fb8
parent1f40dbad60d0a35291f7f43527a6facc82ea1e72
mbedtls: remove MBEDTLS_HAVE_TIME

When MbedTLS TLS features were added MBEDTLS_HAVE_TIME was defined as part
of enabling https:// support. However that pointed to the wrong function
which could crash if it received a NULL pointer.

Looking closer that function is not really needed, as it only seems to
increase the RNG entropy by using 4b of the current time and date.
The reason that was enabled is that lwIP was unconditionally requiring it,
although it's configurable and can be turned off.

Since lwIP doesn't use that field anywhere else, make it conditional and
disable it from our config.

Fixes: commit a564f5094f62 ("mbedtls: Enable TLS 1.2 support")
Reported-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
lib/lwip/lwip/src/apps/altcp_tls/altcp_tls_mbedtls.c
lib/mbedtls/mbedtls_def_config.h