]> git.dujemihanovic.xyz Git - u-boot.git/commit
Revert "sunxi: board: Print error after power initialization fails"
authorFrom: Karl Palsson <karlp@tweak.net.au>
Wed, 19 Dec 2018 13:00:39 +0000 (13:00 +0000)
committerJagan Teki <jagan@amarulasolutions.com>
Sat, 29 Dec 2018 19:27:17 +0000 (00:57 +0530)
commit44c214dc2738da979d277d8d45fe50997b62b5f8
tree408a576de6d8db95bd51edb0d970eaf73703423f
parentbea3d826203f90507ff32ed24bd0a3c53479e55c
Revert "sunxi: board: Print error after power initialization fails"

Commit a8011eb84dfa("sunxi: board: Print error after power initialization
fails") moved the DRAM init after the increase of the CPU clock
frequency. This lead to various DRAM initialisation failures on some
boards (hangs or wrong size reported, on a NanoPi Duo2 and OrangePi
Zero, for instance). Lowering the CPU frequency significantly (for instance
to 408 MHz) seems to work around the problem, so this points to some timing
issues in the DRAM code.

Debugging this sounds like a larger job, so let's just revert this patch
to bring back those boards.
Beside this probably unintended change the patch just moved the error
message around, so reverting this is not a real loss.

This reverts commit a8011eb84dfac5187cebf00ed8bc981bdb5c1fa1.

Tested-By: Priit Laes <plaes@plaes.org>
Signed-off-by: Karl Palsson <karlp@tweak.net.au>
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Jagan Teki <jagan@openedev.com>
board/sunxi/board.c