]> git.dujemihanovic.xyz Git - u-boot.git/commit
mmc: sdhci: fix missing cache invalidation after reading by DMA
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Fri, 14 Feb 2020 07:40:27 +0000 (16:40 +0900)
committerPeng Fan <peng.fan@nxp.com>
Thu, 20 Feb 2020 07:09:57 +0000 (15:09 +0800)
commit4155ad9aac9474610038b525da9eec8ad9afbc12
tree8f1c1a245a342946660d717db55560f68a31e207
parent58d8ace12be763351df37cdcf6fdfceb646fb4dd
mmc: sdhci: fix missing cache invalidation after reading by DMA

This driver currently performs cache operation before the DMA start,
but does nothing after the DMA completion.

When reading data by DMA, the cache invalidation is needed also after
finishing the DMA transfer. Otherwise, the CPU might read data from
the cache instead of from the main memory when speculative memory read
or memory prefetch occurs.

Instead of calling the cache operation directly, this commit adds
dma_unmap_single(), which performs cache invalidation internally,
but drivers do not need which operation is being run.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
drivers/mmc/sdhci.c