]> git.dujemihanovic.xyz Git - u-boot.git/commit
usb: Don't reset the USB hub a 2nd time
authorStefan Roese <sr@denx.de>
Tue, 15 Mar 2016 12:59:14 +0000 (13:59 +0100)
committerMarek Vasut <marex@denx.de>
Sun, 20 Mar 2016 17:00:45 +0000 (18:00 +0100)
commit3ed9eb93c2c7d8e09ac0b5a047f58c3aae201516
treef4ef07d1f4320cefe706625674cc8ed63ecffbfd
parent2ef117fe4fce4e1af282ac2bbb0be36c41d15e2b
usb: Don't reset the USB hub a 2nd time

Debugging has shown, that all USB hubs are being reset twice while
USB scanning. This introduces additional delays and makes USB scanning
even more slow. Testing has shown that this 2nd USB hub reset doesn't
seem to be necessary.

This patch now removes this 2nd USB hub reset. Resulting in faster USB
scan time. Here the current numbers:

Without this patch:
=> time usb start
starting USB...
USB0:   USB EHCI 1.00
scanning bus 0 for devices... 9 USB Device(s) found

time: 24.003 seconds

With this patch:
=> time usb start
starting USB...
USB0:   USB EHCI 1.00
scanning bus 0 for devices... 9 USB Device(s) found

time: 20.392 seconds

So ~3.6 seconds of USB scanning time reduction.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Simon Glass <sjg@chromium.org>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: Stephen Warren <swarren@nvidia.com>
Cc: Marek Vasut <marex@denx.de>
common/usb.c