]> git.dujemihanovic.xyz Git - u-boot.git/commit
projects / u-boot.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 24d98cb) | patch
net: phy: vitesse: Fix cis8204 RGMII_ID code
authorPhil Edworthy <PHIL.EDWORTHY@renesas.com>
Mon, 12 Dec 2016 15:27:12 +0000 (15:27 +0000)
committerJoe Hershberger <joe.hershberger@ni.com>
Tue, 7 Feb 2017 16:54:34 +0000 (10:54 -0600)
commit3b5f52801d5de89e39b95ac155cbcda44d164240
tree572666293b47955bfa2c3bc526535705bc015099tree | snapshot
parent24d98cb42473e8842d6f29854cb1b2b4249bcfbdcommit | diff
net: phy: vitesse: Fix cis8204 RGMII_ID code

Commit 79e86ccb3786c8b20004db3fa10a70049456f580 "vitesse: remove duplicated
argument to ||" correctly removed a redundant check.

However, I believe that the original code was simply wrong, and should have
been checking against RGMII_ID.

To fix this and avoid similar problems in the future, use the
phy_interface_is_rgmii helper function.

Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
drivers/net/phy/vitesse.c diff | blob | history
My U-Boot fork