]> git.dujemihanovic.xyz Git - u-boot.git/commit
malloc_simple: Return NULL on malloc failure rather then calling panic()
authorHans de Goede <hdegoede@redhat.com>
Wed, 4 Feb 2015 12:05:50 +0000 (13:05 +0100)
committerSimon Glass <sjg@chromium.org>
Thu, 12 Feb 2015 17:35:29 +0000 (10:35 -0700)
commit2c8571703a3aacfb09defc35c42c6250a6746d58
tree722128503083a94658d4e1cea23d06c4ffc93111
parenta3e757a5d295329b504123f0995b35cf694c7613
malloc_simple: Return NULL on malloc failure rather then calling panic()

All callers of malloc should already do error checking, and may even be able
to continue without the alloc succeeding.

Moreover, common/malloc_simple.c is the only user of .rodata.str1.1 in
common/built-in.o when building the SPL, triggering this gcc bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54303

Causing .rodata to grow with e.g. 0xc21 bytes, nullifying all benefits of
using malloc_simple in the first place.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Simon Glass <sjg@chromium.org>
common/malloc_simple.c