]> git.dujemihanovic.xyz Git - u-boot.git/commit
video: SIMPLE_PANEL depends on DM_GPIO
authorAsherah Connor <ashe@kivikakk.ee>
Wed, 3 Mar 2021 03:46:47 +0000 (14:46 +1100)
committerAnatolij Gustschin <agust@denx.de>
Sat, 10 Apr 2021 14:50:07 +0000 (16:50 +0200)
commit1bed576d4144236f280427420296c3590d360729
treee19d84b39af9ad5a71b598047ab247029726e1f7
parent1b9ee2882e6bd1c17ab2ec86249aa0347af68242
video: SIMPLE_PANEL depends on DM_GPIO

SIMPLE_PANEL currently only depends on PANEL && BACKLIGHT, but the code
makes references to dm_gpio_set_value and gpio_request_by_name.  These
are defined in drivers/gpio/gpio-uclass.c, so a dependency on DM_GPIO
corrects these link errors:

aarch64-linux-gnu-ld.bfd: drivers/built-in.o: in function `simple_panel_set_backlight':
/home/kameliya/u-boot/drivers/video/simple_panel.c:42: undefined reference to `dm_gpio_set_value'
aarch64-linux-gnu-ld.bfd: drivers/built-in.o: in function `simple_panel_enable_backlight':
/home/kameliya/u-boot/drivers/video/simple_panel.c:27: undefined reference to `dm_gpio_set_value'
aarch64-linux-gnu-ld.bfd: drivers/built-in.o: in function `simple_panel_of_to_plat':
/home/kameliya/u-boot/drivers/video/simple_panel.c:72: undefined reference to `gpio_request_by_name'

This issue is only exposed if you have a board which enables
CONFIG_DM_VIDEO without CONFIG_DM_GPIO; so far, none do, but soon a QEMU
board may.

Signed-off-by: Asherah Connor <ashe@kivikakk.ee>
drivers/video/Kconfig