]> git.dujemihanovic.xyz Git - u-boot.git/commit
image: Avoid erroneous double byte-swap in CRC value
authorAlexandru Gagniuc <mr.nuke.me@gmail.com>
Tue, 14 Sep 2021 20:53:33 +0000 (15:53 -0500)
committerTom Rini <trini@konsulko.com>
Tue, 14 Sep 2021 22:44:02 +0000 (18:44 -0400)
commit1ac7580a225408a46eecb9046ad5f38d7ea4a520
tree54006b6a9d63171e0fc61a1d243f7cc597f75c21
parentc6eac9122f022424f274dede255c793523c25953
image: Avoid erroneous double byte-swap in CRC value

The hash algorithm selection was streamlined in commit 92055e138f28
("image: Drop if/elseif hash selection in calculate_hash()"). Said
commit kept the call to cpu_to_uimage() to convert the CRC to big
endian format.

This would have been correct when calling crc32_wd(). However, the
->hash_func_ws member of crc32 points to crc32_wd_buf(), which already
converts the CRC to big endian. On a little endian host, doing both
conversions results in a little-endian CRC. This is incorrect.

To remedy this, simply drop the call to cpu_to_uimage(), thus only
doing the byte-order conversion once.

Fixes: 92055e138f28 ("image: Drop if/elseif hash selection in
       calculate_hash()")
Tested-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
common/image-fit.c