]> git.dujemihanovic.xyz Git - u-boot.git/commit
projects / u-boot.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: ea1e3f9) | patch
ddr: fsl: incorrect logical constraint in populate_memctl_options
authorxypron.glpk@gmx.de <xypron.glpk@gmx.de>
Sat, 15 Apr 2017 13:23:49 +0000 (15:23 +0200)
committerTom Rini <trini@konsulko.com>
Tue, 18 Apr 2017 14:29:24 +0000 (10:29 -0400)
commit0e0de24b07b8314ea0cc247a89b722c2230e4b0a
treee93e1727b8bfd9f12eb14f3b497808316714bd49tree | snapshot
parentea1e3f96c3666245b3651ab8022738763b97e6a8commit | diff
ddr: fsl: incorrect logical constraint in populate_memctl_options

(pdimm[0].data_width >= 32) || (pdimm[0].data_width <= 40)
is always true.

We should use && here.

The problem was indicated by cppcheck.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Tom Rini <trini@konsulko.com>
Reviewed-by: York Sun <york.sun@nxp.com>
drivers/ddr/fsl/options.c diff | blob | history
My U-Boot fork