From 0fac5c47e4b82b78740264fd4ca53cd2ab28b34e Mon Sep 17 00:00:00 2001 From: Rasmus Villemoes <rasmus.villemoes@prevas.dk> Date: Wed, 19 Apr 2023 12:10:13 +0200 Subject: [PATCH] gpio-uclass: fix off-by-one in gpio_request_list_by_name_nodev() By the time we jump to the err label, count represents the number of gpios we've successfully requested. So by subtracting one, we fail to free the most recently requested. Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk> Reviewed-by: Simon Glass <sjg@chromium.org> --- drivers/gpio/gpio-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-uclass.c b/drivers/gpio/gpio-uclass.c index c8be5a4d66..712119c341 100644 --- a/drivers/gpio/gpio-uclass.c +++ b/drivers/gpio/gpio-uclass.c @@ -1219,7 +1219,7 @@ int gpio_request_list_by_name_nodev(ofnode node, const char *list_name, return count; err: - gpio_free_list_nodev(desc, count - 1); + gpio_free_list_nodev(desc, count); return ret; } -- 2.39.5