From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Date: Wed, 11 May 2022 14:12:50 +0000 (+0200)
Subject: net: dwc_eth_qos: fix double resource leak in eqos_remove()
X-Git-Tag: v2025.01-rc5-pxa1908~1320^2~12
X-Git-Url: http://git.dujemihanovic.xyz/%7B%7B%20%24style.RelPermalink%20%7D%7D?a=commitdiff_plain;h=4a7c9dbf9a42330970a9742c1d476f2a9075f3f9;p=u-boot.git

net: dwc_eth_qos: fix double resource leak in eqos_remove()

Not only does eqos_remove() fail to free the buffers that have been
allocated by eqos_probe_resources_core(), it repeats those allocations
and thus drops twice as much memory on the floor.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
---

diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
index c1f2391d63..7c504dd1ca 100644
--- a/drivers/net/dwc_eth_qos.c
+++ b/drivers/net/dwc_eth_qos.c
@@ -1574,7 +1574,7 @@ static int eqos_remove(struct udevice *dev)
 	eqos->config->ops->eqos_stop_clks(dev);
 	eqos->config->ops->eqos_remove_resources(dev);
 
-	eqos_probe_resources_core(dev);
+	eqos_remove_resources_core(dev);
 
 	debug("%s: OK\n", __func__);
 	return 0;