]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
stm32mp1: spl: Fix compilation warnings
authorPatrice Chotard <patrice.chotard@foss.st.com>
Tue, 11 Jun 2024 09:52:38 +0000 (11:52 +0200)
committerPatrice Chotard <patrice.chotard@foss.st.com>
Fri, 14 Jun 2024 11:25:06 +0000 (13:25 +0200)
Fix the following compilation warnings :

../arch/arm/mach-stm32mp/stm32mp1/spl.c: In function 'stm32_init_tzc_for_optee':
../arch/arm/mach-stm32mp/stm32mp1/spl.c:148:37: warning: 'optee_size' may be used uninitialized [-Wmaybe-uninitialized]
  148 |         tee_shmem_base = optee_base + optee_size - CFG_SHMEM_SIZE;
      |                          ~~~~~~~~~~~^~~~~~~~~~~~
../arch/arm/mach-stm32mp/stm32mp1/spl.c:137:30: note: 'optee_size' was declared here
  137 |         uint32_t optee_base, optee_size, tee_shmem_base;
      |                              ^~~~~~~~~~
../arch/arm/mach-stm32mp/stm32mp1/spl.c:148:37: warning: 'optee_base' may be used
uninitialized [-Wmaybe-uninitialized]
  148 |         tee_shmem_base = optee_base + optee_size - CFG_SHMEM_SIZE;
      |                          ~~~~~~~~~~~^~~~~~~~~~~~
../arch/arm/mach-stm32mp/stm32mp1/spl.c:137:18: note: 'optee_base' was declared here
  137 |         uint32_t optee_base, optee_size, tee_shmem_base;
      |                  ^~~~~~~~~~

Fix also the following checkpatch "check" :

CHECK: Prefer kernel type 'u32' over 'uint32_t'
37: FILE: arch/arm/mach-stm32mp/stm32mp1/spl.c:137:
+ uint32_t optee_base = 0, optee_size = 0, tee_shmem_base;

Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
arch/arm/mach-stm32mp/stm32mp1/spl.c

index 6c79259b2c82147fb94ea2b575beb34add1658cb..10abbed87f0f5a5512f936c94befd00dc5fedda9 100644 (file)
@@ -134,7 +134,7 @@ void stm32_init_tzc_for_optee(void)
 {
        const uint32_t dram_size = stm32mp_get_dram_size();
        const uintptr_t dram_top = STM32_DDR_BASE + (dram_size - 1);
-       uint32_t optee_base, optee_size, tee_shmem_base;
+       u32 optee_base = 0, optee_size = 0, tee_shmem_base;
        const uintptr_t tzc = STM32_TZC_BASE;
        int ret;