]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
arm: dts: db410c: Add missing cd-gpios for SD card detection
authorStephan Gerhold <stephan@gerhold.net>
Sun, 27 Jun 2021 11:06:15 +0000 (13:06 +0200)
committerTom Rini <trini@konsulko.com>
Tue, 6 Jul 2021 18:12:15 +0000 (14:12 -0400)
It looks like SD card detection is broken at the moment for DB410c.
The eMMC is detected correctly, but the SD card is not.

This is probably similar to the issue fixed in commit 850514740358
("mmc: msm_sdhci: Use mmc_of_parse for setting host_caps") for eMMC,
except that the SD card does not have a property like "non-removable"
that skips the card detection.

The SDHCI on DB410c cannot detect itself if a SD card is inserted,
so add the necessary cd-gpios to make SD card detection work again.

While at it, fix the #gpio-cells for the soc_gpios to avoid DTC
warnings - the soc_gpios are actually already used with two cells
for the gpio-leds so this was just wrong all the time.

Cc: Ramon Fried <rfried.dev@gmail.com>
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
arch/arm/dts/dragonboard410c.dts

index fa348bc621eadd59d2beb5593054e768106e7d78..7e56140df26c461f722a1b7b214c604d763616b3 100644 (file)
@@ -8,6 +8,7 @@
 /dts-v1/;
 
 #include "skeleton64.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/pinctrl/pinctrl-snapdragon.h>
 
 / {
@@ -91,7 +92,7 @@
                        gpio-controller;
                        gpio-count = <122>;
                        gpio-bank-name="soc";
-                       #gpio-cells = <1>;
+                       #gpio-cells = <2>;
                };
 
                ehci@78d9000 {
                        bus-width = <0x4>;
                        clock = <&clkc 1>;
                        clock-frequency = <200000000>;
+                       cd-gpios = <&soc_gpios 38 GPIO_ACTIVE_LOW>;
                };
 
                wcnss {