]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
pinctrl: rockchip: rk3188: Fix support for IOMUX_GPIO_ONLY flag
authorJonas Karlman <jonas@kwiboo.se>
Sun, 12 May 2024 12:16:14 +0000 (12:16 +0000)
committerKever Yang <kever.yang@rock-chips.com>
Fri, 14 Jun 2024 09:02:49 +0000 (17:02 +0800)
GPIO0_A0-A7 on RK3188 is IOMUX_GPIO_ONLY, however, trying to set gpio
mux return an -ENOTSUPP error code. Fix this by validating using the mux
function type and not the iomux flag.

Based on Linux commit c4a532dee6b6 ("pinctrl: rockchip: handle first
half of rk3188-bank0 correctly").

Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
drivers/pinctrl/rockchip/pinctrl-rockchip-core.c

index 8ef089994f467f74821601a68c024aa805f01f91..a3cdadb86b1df38a3776fc43760805ac37484833 100644 (file)
@@ -172,7 +172,7 @@ static int rockchip_verify_mux(struct rockchip_pin_bank *bank,
        }
 
        if (bank->iomux[iomux_num].type & IOMUX_GPIO_ONLY) {
-               if (mux != IOMUX_GPIO_ONLY) {
+               if (mux != RK_FUNC_GPIO) {
                        debug("pin %d only supports a gpio mux\n", pin);
                        return -ENOTSUPP;
                }