]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
video: tegra20: dc: enable backlight after DC is configured
authorJonas Schwöbel <jonasschwoebel@yahoo.de>
Tue, 23 Jan 2024 17:16:25 +0000 (19:16 +0200)
committerAnatolij Gustschin <agust@denx.de>
Sun, 21 Apr 2024 07:07:01 +0000 (09:07 +0200)
The goal of panel_set_backlight() is to enable backlight. Hence,
it should be called at the probe end.

Signed-off-by: Jonas Schwöbel <jonasschwoebel@yahoo.de>
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
drivers/video/tegra20/tegra-dc.c

index 856d507cc5c61fcb20dffaaa2d6cdd04a7f61e85..07d6ac9d718cc0b1f878150473434ecb8d585e3e 100644 (file)
@@ -397,12 +397,6 @@ static int tegra_lcd_probe(struct udevice *dev)
                return ret;
        }
 
-       ret = panel_set_backlight(priv->panel, BACKLIGHT_DEFAULT);
-       if (ret) {
-               debug("%s: Cannot set backlight to default, ret=%d\n", __func__, ret);
-               return ret;
-       }
-
        mmu_set_region_dcache_behaviour(priv->frame_buffer, plat->size,
                                        DCACHE_WRITETHROUGH);
 
@@ -415,7 +409,7 @@ static int tegra_lcd_probe(struct udevice *dev)
        debug("LCD frame buffer at %08x, size %x\n", priv->frame_buffer,
              plat->size);
 
-       return 0;
+       return panel_set_backlight(priv->panel, BACKLIGHT_DEFAULT);
 }
 
 static int tegra_lcd_of_to_plat(struct udevice *dev)