cmd: bootefi: error handling bootefi selftest

If bootefi selftest is executed and a problem with the device-tree
installation occurs, efi_install_fdt() writes sensible error messages.
It never returns EFI_INVALID_PARAMETER. It neither makes sense to check
for EFI_INVALID_PARAMETER nor to show the usage help for the bootefi
command in this case.

Fixes: 296faf4f7ef1 ("cmd: bootefi: re-organize do_bootefi()")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

diff --git a/cmd/bootefi.c b/cmd/bootefi.c
index b509440cde0812dd4e406f4b7f80c26409e7dfb5..578dbb19a7e5e5f8c583ca07f53900018ba77968 100644 (file)
--- a/cmd/bootefi.c
+++ b/cmd/bootefi.c
@@ -171,9 +171,7 @@ static int do_bootefi(struct cmd_tbl *cmdtp, int flag, int argc,
                }
 
                ret = efi_install_fdt(fdt);
-               if (ret == EFI_INVALID_PARAMETER)
-                       return CMD_RET_USAGE;
-               else if (ret != EFI_SUCCESS)
+               if (ret != EFI_SUCCESS)
                        return CMD_RET_FAILURE;
 
                return do_efi_selftest();