]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
mmc: dw_mmc: Extract FIFO init into a separate routine
authorSam Protsenko <semen.protsenko@linaro.org>
Thu, 8 Aug 2024 03:14:10 +0000 (22:14 -0500)
committerMinkyu Kang <mk7.kang@samsung.com>
Mon, 19 Aug 2024 07:09:06 +0000 (16:09 +0900)
Move FIFO threshold initialization into a separate function to make
dwmci_init() more readable.

No functional change.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
drivers/mmc/dw_mmc.c

index 395b699b0a0a26833170e709c7486ea7653d1a10..4a9e57165fbbb7a5c4a7c03226fee4f960273127 100644 (file)
@@ -538,6 +538,20 @@ static int dwmci_set_ios(struct mmc *mmc)
        return 0;
 }
 
+static void dwmci_init_fifo(struct dwmci_host *host)
+{
+       if (!host->fifoth_val) {
+               u32 fifo_size;
+
+               fifo_size = dwmci_readl(host, DWMCI_FIFOTH);
+               fifo_size = ((fifo_size & RX_WMARK_MASK) >> RX_WMARK_SHIFT) + 1;
+               host->fifoth_val = MSIZE(0x2) | RX_WMARK(fifo_size / 2 - 1) |
+                                  TX_WMARK(fifo_size / 2);
+       }
+
+       dwmci_writel(host, DWMCI_FIFOTH, host->fifoth_val);
+}
+
 static int dwmci_init(struct mmc *mmc)
 {
        struct dwmci_host *host = mmc->priv;
@@ -562,16 +576,7 @@ static int dwmci_init(struct mmc *mmc)
 
        dwmci_writel(host, DWMCI_IDINTEN, 0);
        dwmci_writel(host, DWMCI_BMOD, 1);
-
-       if (!host->fifoth_val) {
-               uint32_t fifo_size;
-
-               fifo_size = dwmci_readl(host, DWMCI_FIFOTH);
-               fifo_size = ((fifo_size & RX_WMARK_MASK) >> RX_WMARK_SHIFT) + 1;
-               host->fifoth_val = MSIZE(0x2) | RX_WMARK(fifo_size / 2 - 1) |
-                               TX_WMARK(fifo_size / 2);
-       }
-       dwmci_writel(host, DWMCI_FIFOTH, host->fifoth_val);
+       dwmci_init_fifo(host);
 
        dwmci_writel(host, DWMCI_CLKENA, 0);
        dwmci_writel(host, DWMCI_CLKSRC, 0);