]> git.dujemihanovic.xyz Git - u-boot.git/commit
binman: fix passing loadables to mkimage on first run
authorAlexander Kochetkov <al.kochet@gmail.com>
Mon, 16 Sep 2024 08:24:44 +0000 (11:24 +0300)
committerSimon Glass <sjg@chromium.org>
Fri, 18 Oct 2024 20:10:22 +0000 (14:10 -0600)
commit7c4e5223cbce11b21848db75092c7c172649c7d4
treea1d24b34f7fff8b570f43dfa55010ace09df3e2b
parentaa0b3e6ef405c01063298cf3c990ae490a673e5e
binman: fix passing loadables to mkimage on first run

FIT use mkimage from BuildSectionData() to build FIT entry contents.
BuildSectionData() get called several times during building FIT image.

Currently when fit inserts loadables, it use self._loadables property that
contain loadables computed during previuos BuildSectionData() invocation.
So for the first run it use empty list and pass no loadables to mkimage.

That makes problem for adding signature to FIT image because mkimage
fails to add signature and aborts building FIT if no loadables provided.

The patch fixes described behaviour in a way that BuildSectionData() uses
recently calculated loadables value, not previosly calculated.

Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
tools/binman/etype/fit.py