]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
smccc: fix sign bit expansion
authorVolodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Tue, 5 Jan 2021 20:03:11 +0000 (20:03 +0000)
committerTom Rini <trini@konsulko.com>
Wed, 27 Jan 2021 21:58:57 +0000 (16:58 -0500)
Signed ARM_SMCCC_FAST_CALL value is shifted to 31'st bit. Then, it is expanded
to 64 bit value, which results in 1s in higher 32 bits.

This causes corrupted values in 64-bit SMC IDs and issues in buggy handlers of
32-bit calls.

We need to make ARM_SMCCC_FAST_CALL unsigned long, so it would work properly
on 32 bit architectures.

Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
include/linux/arm-smccc.h

index 2d1e6cc1564dd0a6aac1310ac6c8a0e7d13b7d4c..7f2be2339475ec56c71bb2ad52f5535a0f19ad6a 100644 (file)
@@ -11,8 +11,8 @@
  * http://infocenter.arm.com/help/topic/com.arm.doc.den0028a/index.html
  */
 
-#define ARM_SMCCC_STD_CALL             0
-#define ARM_SMCCC_FAST_CALL            1
+#define ARM_SMCCC_STD_CALL             0UL
+#define ARM_SMCCC_FAST_CALL            1UL
 #define ARM_SMCCC_TYPE_SHIFT           31
 
 #define ARM_SMCCC_SMC_32               0