]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
tools: binman: ti_board_cfg: improve error message
authorMichael Walle <mwalle@kernel.org>
Tue, 26 Mar 2024 09:39:34 +0000 (10:39 +0100)
committerTom Rini <trini@konsulko.com>
Thu, 11 Apr 2024 21:51:33 +0000 (15:51 -0600)
When there is a lint error the user gets the following cryptic message:

  binman: Node '/path/to/some/node': Yamllint error: 18: comments

This isn't very helpful. Improve the message to tell the user that the
number is actually a line number and also tell the user in which file
they have to look.

Signed-off-by: Michael Walle <mwalle@kernel.org>
Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
tools/binman/etype/ti_board_config.py

index 2c3bb8f7b56ad40ee5ec474771403e37ddf54a36..c10d66edcb15309b327aa5221b5bc0ff6c815804 100644 (file)
@@ -248,7 +248,7 @@ class Entry_ti_board_config(Entry_section):
 
             yaml_config = config.YamlLintConfig("extends: default")
             for p in yamllint.linter.run(open(self._config_file, "r"), yaml_config):
-                self.Raise(f"Yamllint error: {p.line}: {p.rule}")
+                self.Raise(f"Yamllint error: Line {p.line} in {self._config_file}: {p.rule}")
             try:
                 validate(self.file_yaml, self.schema_yaml)
             except Exception as e: