efi: clean up efi command

* Eliminate superfluous enum value EFI_TABLE_END.
* Use correct variable type for the memory type.
* Check validity of memory type.
* Make efi_build_mem_table static.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

diff --git a/cmd/efi.c b/cmd/efi.c
index b3a3bf828215e82a9dd0bcb384f4bada6cb3bfd0..1558cb17eb0a58c6f7da4ab8b028c4285a3d8a65 100644 (file)
--- a/cmd/efi.c
+++ b/cmd/efi.c
@@ -71,7 +71,19 @@ static int h_cmp_entry(const void *v1, const void *v2)
        return diff < 0 ? -1 : diff > 0 ? 1 : 0;
 }
 
-void *efi_build_mem_table(struct efi_entry_memmap *map, int size, bool skip_bs)
+/**
+ * efi_build_mem_table() - make a sorted copy of the memory table
+ *
+ * @map:       Pointer to EFI memory map table
+ * @size:      Size of table in bytes
+ * @skip_bs:   True to skip boot-time memory and merge it with conventional
+ *             memory. This will significantly reduce the number of table
+ *             entries.
+ * Return:     pointer to the new table. It should be freed with free() by the
+ *             caller.
+ */
+static void *efi_build_mem_table(struct efi_entry_memmap *map, int size,
+                                bool skip_bs)
 {
        struct efi_mem_desc *desc, *end, *base, *dest, *prev;
        int count;
@@ -92,7 +104,13 @@ void *efi_build_mem_table(struct efi_entry_memmap *map, int size, bool skip_bs)
        end = (struct efi_mem_desc *)((ulong)base + count * map->desc_size);
        for (desc = base; desc < end; desc = efi_get_next_mem_desc(map, desc)) {
                bool merge = true;
-               int type = desc->type;
+               u32 type = desc->type;
+
+               if (type >= EFI_MAX_MEMORY_TYPE) {
+                       printf("Memory map contains invalid entry type %u\n",
+                              type);
+                       continue;
+               }
 
                if (skip_bs && is_boot_services(desc->type))
                        type = EFI_CONVENTIONAL_MEMORY;
@@ -119,7 +137,7 @@ void *efi_build_mem_table(struct efi_entry_memmap *map, int size, bool skip_bs)
        }
 
        /* Mark the end */
-       dest->type = EFI_TABLE_END;
+       dest->type = EFI_MAX_MEMORY_TYPE;
 
        return base;
 }
@@ -138,7 +156,7 @@ static void efi_print_mem_table(struct efi_entry_memmap *map,
        /* Keep track of all the different attributes we have seen */
        attr_seen_count = 0;
        addr = 0;
-       for (upto = 0; desc->type != EFI_TABLE_END;
+       for (upto = 0; desc->type != EFI_MAX_MEMORY_TYPE;
             upto++, desc = efi_get_next_mem_desc(map, desc)) {
                const char *name;
                u64 size;

diff --git a/include/efi.h b/include/efi.h
index f986aad8777757c2e1deef4a9c0c847d37334f19..5695273ce9afad9084d32941d729ddedb8eaec25 100644 (file)
--- a/include/efi.h
+++ b/include/efi.h
@@ -180,7 +180,6 @@ enum efi_mem_type {
        EFI_PERSISTENT_MEMORY_TYPE,
 
        EFI_MAX_MEMORY_TYPE,
-       EFI_TABLE_END,  /* For efi_build_mem_table() */
 };
 
 /* Attribute values */
@@ -481,17 +480,4 @@ void efi_putc(struct efi_priv *priv, const char ch);
  */
 int efi_info_get(enum efi_entry_t type, void **datap, int *sizep);
 
-/**
- * efi_build_mem_table() - make a sorted copy of the memory table
- *
- * @map:       Pointer to EFI memory map table
- * @size:      Size of table in bytes
- * @skip_bs:   True to skip boot-time memory and merge it with conventional
- *             memory. This will significantly reduce the number of table
- *             entries.
- * @return pointer to the new table. It should be freed with free() by the
- *        caller
- */
-void *efi_build_mem_table(struct efi_entry_memmap *map, int size, bool skip_bs);
-
 #endif /* _LINUX_EFI_H */