cmd: ubifs: Do not show usage when command fails

Return value -1 cause U-Boot to print usage message. Return value
1 (CMD_RET_FAILURE) indicates failure. So fix return value when ubifs
command starts it execution and fails.

Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Dhruva Gole <d-gole@ti.com>

diff --git a/cmd/ubifs.c b/cmd/ubifs.c
index 7a620c5e21da6947d67c5f2df79678fdc9bfd8be..6a01d0988a2da4ebdade2bb7149790f29eec7737 100644 (file)
--- a/cmd/ubifs.c
+++ b/cmd/ubifs.c
@@ -33,7 +33,7 @@ int cmd_ubifs_mount(char *vol_name)
 
        ret = uboot_ubifs_mount(vol_name);
        if (ret)
-               return -1;
+               return CMD_RET_FAILURE;
 
        ubifs_mounted = 1;
 
@@ -62,7 +62,7 @@ int cmd_ubifs_umount(void)
 {
        if (ubifs_initialized == 0) {
                printf("No UBIFS volume mounted!\n");
-               return -1;
+               return CMD_RET_FAILURE;
        }
 
        uboot_ubifs_umount();
@@ -89,7 +89,7 @@ static int do_ubifs_ls(struct cmd_tbl *cmdtp, int flag, int argc,
 
        if (!ubifs_mounted) {
                printf("UBIFS not mounted, use ubifsmount to mount volume first!\n");
-               return -1;
+               return CMD_RET_FAILURE;
        }
 
        if (argc == 2)
@@ -116,7 +116,7 @@ static int do_ubifs_load(struct cmd_tbl *cmdtp, int flag, int argc,
 
        if (!ubifs_mounted) {
                printf("UBIFS not mounted, use ubifs mount to mount volume first!\n");
-               return -1;
+               return CMD_RET_FAILURE;
        }
 
        if (argc < 3)