]> git.dujemihanovic.xyz Git - u-boot.git/commit
x86: mtrr: Fix parsing of "mtrr list" command
authorWolfgang Wallner <wolfgang.wallner@br-automation.com>
Fri, 14 Aug 2020 07:55:24 +0000 (09:55 +0200)
committerBin Meng <bmeng.cn@gmail.com>
Tue, 1 Sep 2020 05:24:45 +0000 (13:24 +0800)
commitcf9f38064d048ac12cd3a7e1a40a84aa8071f712
treef91d497db2ee0998a3dbbeb31b996ac1d03cb9ed
parent23e333a5c083a000d0cabc53f7c0d261bae9e5ca
x86: mtrr: Fix parsing of "mtrr list" command

The command 'mtrr' does not recognize the 'list' subcommand any more
since the code restructuring in commit b2a76b3fe75a ("x86: mtrr:
Restructure so command execution is in one place").

The if-else parsing the command arguments does not take 'list' into
account: the if-branch is intended for no subcommands, the else-branch
is intended for the non-list subcommands (which all expect additional
arguments). Calling the 'mtrr list' subcommand leads to a "return
CMD_RET_USAGE" in the else-branch.

Fix this by changing the else-branch to explicitly checking for
if (cmd != 'l').

Fixes: b2a76b3fe75a ("x86: mtrr: Restructure so command execution is in one place")
Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>
cmd/x86/mtrr.c