]> git.dujemihanovic.xyz Git - u-boot.git/commit
cmd: bcb: Fix segfault on invalid block device
authorMattijs Korpershoek <mkorpershoek@baylibre.com>
Wed, 24 Jul 2024 09:51:06 +0000 (11:51 +0200)
committerMattijs Korpershoek <mkorpershoek@baylibre.com>
Thu, 22 Aug 2024 07:23:33 +0000 (09:23 +0200)
commit61faa6dd21f661cab95aa00a6660441a5f04f8db
treed705ef7ff236566e5b8b84436b800b1690beea8f
parent0b06e052fb153958d470209dab237f12796cb0da
cmd: bcb: Fix segfault on invalid block device

When blk_get_dev() fails, block NULL and gets de-referenced in
the error path by a printf(), resulting in a crash.

This can be reproduced on sandbox with:

$ ./u-boot --command "bcb load mmc 0 0"

Fix the message by using the functions arguments (iface, devnum)
instead.

Note: partition (being a global static initialized) can be used safely.

This issue has been reported by coverity [1]

[1] https://lore.kernel.org/all/20240723141844.GF989285@bill-the-cat/

Fixes: dfeb4f0d7935 ("cmd: bcb: extend BCB C API to allow read/write the fields")
Reviewed-by: Dmitrii Merkurev <dimorinny@google.com>
Link: https://lore.kernel.org/r/20240724-bcb-crash-v1-1-44caff15bce4@baylibre.com
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
cmd/bcb.c