]> git.dujemihanovic.xyz Git - u-boot.git/commit
usb: dwc3: gadget: Disable GUSB2PHYCFG.SUSPHY for End Transfer
authorThinh Nguyen <Thinh.Nguyen@synopsys.com>
Fri, 12 Apr 2024 20:26:06 +0000 (22:26 +0200)
committerMattijs Korpershoek <mkorpershoek@baylibre.com>
Thu, 16 May 2024 06:38:24 +0000 (08:38 +0200)
commit30f39de786ff3a87006461903e41a48c811ee764
tree4992ebbe8cf028c9264d1628cacb246f8afe01fc
parent95b4d655a44626f888bf823a0561a175d456d33a
usb: dwc3: gadget: Disable GUSB2PHYCFG.SUSPHY for End Transfer

Upstream Linux commit 3aa07f72894d.

If there's a disconnection while operating in eSS, there may be a delay
in VBUS drop response from the connector. In that case, the internal
link state may drop to operate in usb2 speed while the controller thinks
the VBUS is still high. The driver must make sure to disable
GUSB2PHYCFG.SUSPHY when sending endpoint command while in usb2 speed.
The End Transfer command may be called, and only that command needs to
go through at this point. Let's keep it simple and unconditionally
disable GUSB2PHYCFG.SUSPHY whenever we issue the command.

This scenario is not seen in real hardware. In a rare case, our
prototype type-c controller/interface may have a slow response
triggerring this issue.

Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/5651117207803c26e2f22ddf4e5ce9e865dcf7c7.1668045468.git.Thinh.Nguyen@synopsys.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Link: https://lore.kernel.org/r/20240412202611.3565052-7-alexander.sverdlin@siemens.com
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
drivers/usb/dwc3/gadget.c