From 5a5d1def59024dd3225e2a6142f8ee3ee10180a8 Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt <xypron.glpk@gmx.de> Date: Tue, 3 Sep 2019 00:05:05 +0200 Subject: [PATCH] net: nfs: remove superfluous packed attribute MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit With GCC 9.2.1 net/nfs.c leads to multiple errors of type address-of-packed-member. net/nfs.c: In function ârpc_reqâ: net/nfs.c:199:18: error: taking address of packed member of âstruct rpc_tâ may result in an unaligned pointer value [-Werror=address-of-packed-member] 199 | p = (uint32_t *)&(rpc_pkt.u.call.data); | ^~~~~~~~~~~~~~~~~~~~~~ net/nfs.c: In function ânfs_readlink_replyâ: net/nfs.c:631:46: error: taking address of packed member of âstruct rpc_tâ may result in an unaligned pointer value [-Werror=address-of-packed-member] 631 | nfs3_get_attributes_offset(rpc_pkt.u.reply.data); | ~~~~~~~~~~~~~~~^~~~~ LD drivers/block/built-in.o net/nfs.c: In function ânfs_read_replyâ: net/nfs.c:692:46: error: taking address of packed member of âstruct rpc_tâ may result in an unaligned pointer value [-Werror=address-of-packed-member] 692 | nfs3_get_attributes_offset(rpc_pkt.u.reply.data); | ~~~~~~~~~~~~~~~^~~~~ struct rpc_t is only used as local variable. It is naturally packed. So there is no need for the attribute packed. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Acked-by: Joe Hershberger <joe.hershberger@ni.com> --- net/nfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/nfs.h b/net/nfs.h index a377c90088..68ada0efeb 100644 --- a/net/nfs.h +++ b/net/nfs.h @@ -78,7 +78,7 @@ struct rpc_t { NFS_MAX_ATTRS]; } reply; } u; -} __attribute__((packed)); +}; void nfs_start(void); /* Begin NFS */ -- 2.39.5