From: Heinrich Schuchardt Date: Mon, 11 Jul 2022 18:01:12 +0000 (+0200) Subject: cmd: undefined return value of do_extension_apply() X-Git-Tag: v2025.01-rc5-pxa1908~1325^2~13 X-Git-Url: http://git.dujemihanovic.xyz/%22/img/sics.gif/%22/static/git-favicon.png?a=commitdiff_plain;h=689525b12e00881b88cc8f02c9c711ae9b2f6b5a;p=u-boot.git cmd: undefined return value of do_extension_apply() If 'extension apply all' is executed and no extension is found, the return value of do_extension_apply() is undefined. Return CMD_RET_FAILURE in this case. Fixes: 2f84e9cf06d3 ("cmd: add support for a new "extension" command") Signed-off-by: Heinrich Schuchardt Reviewed-by: Kory Maincent --- diff --git a/cmd/extension_board.c b/cmd/extension_board.c index bbb4812ff8..f94abd612d 100644 --- a/cmd/extension_board.c +++ b/cmd/extension_board.c @@ -111,6 +111,7 @@ static int do_extension_apply(struct cmd_tbl *cmdtp, int flag, return CMD_RET_USAGE; if (strcmp(argv[1], "all") == 0) { + ret = CMD_RET_FAILURE; list_for_each_entry(extension, &extension_list, list) { ret = extension_apply(extension); if (ret != CMD_RET_SUCCESS)