]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
binman: Split node-reading out from constructor in files
authorSimon Glass <sjg@chromium.org>
Tue, 6 Jul 2021 16:36:38 +0000 (10:36 -0600)
committerSimon Glass <sjg@chromium.org>
Wed, 21 Jul 2021 16:27:35 +0000 (10:27 -0600)
The constructor should not read the node information. Move it to the
ReadNode() method instead. This allows this etype to be subclassed.

Signed-off-by: Simon Glass <sjg@chromium.org>
tools/binman/etype/files.py

index 5db36abef0b59fd506e91b15b93662eed7c4a0d2..9b04a496a85189fa99df3b29b315568e46a76b2e 100644 (file)
@@ -34,6 +34,9 @@ class Entry_files(Entry_section):
         from binman import state
 
         super().__init__(section, etype, node)
+
+    def ReadNode(self):
+        super().ReadNode()
         self._pattern = fdt_util.GetString(self._node, 'pattern')
         if not self._pattern:
             self.Raise("Missing 'pattern' property")