]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
cmd: bcb: change strcmp() usage style in the do_bcb_ab_select()
authorDmitry Rokosov <ddrokosov@salutedevices.com>
Thu, 17 Oct 2024 14:12:09 +0000 (17:12 +0300)
committerMattijs Korpershoek <mkorpershoek@baylibre.com>
Thu, 24 Oct 2024 07:45:55 +0000 (09:45 +0200)
In the entire cmd/bcb.c file, the return value of strcmp() is not
directly compared to 0. Therefore, it would be better to maintain this
style in the new do_bcb_ab_select() function as well.

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Tested-by: Guillaume La Roque <glaroque@baylibre.com>
Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> # vim3_android
Link: https://lore.kernel.org/r/20241017-android_ab_master-v5-4-43bfcc096d95@salutedevices.com
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
cmd/bcb.c

index 2854408e5669b0d7d2a06073fa81158b21834b99..b33c046af0385a112fd40634ab7f48e05542ca48 100644 (file)
--- a/cmd/bcb.c
+++ b/cmd/bcb.c
@@ -391,7 +391,7 @@ __maybe_unused static int do_bcb_ab_select(struct cmd_tbl *cmdtp,
                return CMD_RET_USAGE;
 
        for (int i = 4; i < argc; i++) {
-               if (strcmp(argv[i], "--no-dec") == 0)
+               if (!strcmp(argv[i], "--no-dec"))
                        dec_tries = false;
                else
                        return CMD_RET_USAGE;