]> git.dujemihanovic.xyz Git - u-boot.git/commit
IOMUX: Fix access past end of console_devices
authorSean Anderson <seanga2@gmail.com>
Wed, 6 Apr 2022 18:36:35 +0000 (14:36 -0400)
committerTom Rini <trini@konsulko.com>
Tue, 19 Apr 2022 18:52:34 +0000 (14:52 -0400)
commit9dc775aabb73b1d587c7fcfca2ed7b0559576807
tree70b9a1d4af7cad7328f0c610657a4fc90e51d1f9
parent24c904f309f820f8aef4d6364e7bf584d70c0cad
IOMUX: Fix access past end of console_devices

We should only access console_devices[file][i] once we have checked that i
< cd_count[file]. Otherwise, we will access uninitialized memory at the end
of the loop. console_devices[file][i] should not be NULL, but putting the
assignment in the loop condition allows us to ensure that i is checked
beforehand. This isn't a bug, but it does make valgrind stop complaining.

Fixes: 400797cad3 ("IOMUX: Split out for_each_console_dev() helper macro")
Signed-off-by: Sean Anderson <seanga2@gmail.com>
Reviewed-by: Andrew Scull <ascull@google.com>
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
include/iomux.h