]> git.dujemihanovic.xyz Git - u-boot.git/commit
libfdt: Allow #size-cells of 0
authorMatthias Brugger <mbrugger@suse.com>
Thu, 5 Sep 2019 08:48:48 +0000 (10:48 +0200)
committerSimon Glass <sjg@chromium.org>
Tue, 15 Oct 2019 14:40:02 +0000 (08:40 -0600)
commit8076fc298ee1004cfbd9f9f4882931aff1ffda06
tree4e6ed96923fbc9d68f6713c744da70c8db55fc85
parent0ba41ce1b7816c229cc19e0621148b98f990cb68
libfdt: Allow #size-cells of 0

The commit "libfdt: fdt_address_cells() and fdt_size_cells()" introduced
a bug as it consolidated code between the helpers for getting
be 0, and is frequently found so in practice for /cpus.  IEEE1275 only
requires implementations to handle 1..4 for #address-cells, although one
could make a case for #address-cells == #size-cells == 0 being used to
represent a bridge with a single port.

While we're there, it's not totally obvious that the existing implicit
cast of a u32 to int will give the correct results according to strict C,
although it does work in practice.  Straighten that up to cast only after
we've made our range checks.

This is based on upstream commit:
b8d6eca ("libfdt: Allow #size-cells of 0")
but misses the test cases,as we don't implement them in U-Boot.

Signed-off-by: Matthias Brugger <mbrugger@suse.com>
scripts/dtc/libfdt/fdt_addresses.c